Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failures on 32-bit platforms (attempt 3) #2527

Merged
merged 1 commit into from
Feb 26, 2023

Conversation

kevinbackhouse
Copy link
Collaborator

Trying this idea: #2522 (comment)

@kevinbackhouse kevinbackhouse marked this pull request as draft February 26, 2023 14:17
@ghost
Copy link

ghost commented Feb 26, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Feb 26, 2023

Codecov Report

Merging #2527 (5d98f71) into main (230fbaf) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2527      +/-   ##
==========================================
- Coverage   64.66%   64.65%   -0.02%     
==========================================
  Files         103      103              
  Lines       22249    22232      -17     
  Branches    10859    10858       -1     
==========================================
- Hits        14388    14373      -15     
+ Misses       5620     5618       -2     
  Partials     2241     2241              
Impacted Files Coverage Δ
src/pentaxmn_int.cpp 71.86% <0.00%> (-0.87%) ⬇️
src/properties.cpp 75.45% <0.00%> (-0.44%) ⬇️
include/exiv2/value.hpp 85.32% <0.00%> (-0.20%) ⬇️
src/tiffcomposite_int.hpp 90.09% <0.00%> (-0.18%) ⬇️
app/exiv2.cpp 63.24% <0.00%> (-0.08%) ⬇️
src/http.cpp 0.00% <0.00%> (ø)
app/actions.cpp 67.91% <0.00%> (ø)
src/basicio.cpp 51.90% <0.00%> (ø)
src/sonymn_int.cpp 80.48% <0.00%> (ø)
src/matroskavideo.cpp 4.52% <0.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not been following the previous attempts but this one looks good to me 😉

@neheb neheb merged commit 4a6d786 into Exiv2:main Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants