coverity: remove dead code #2525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2525 +/- ##
==========================================
+ Coverage 64.65% 64.67% +0.02%
==========================================
Files 103 103
Lines 22232 22225 -7
Branches 10858 10859 +1
==========================================
Hits 14373 14373
+ Misses 5618 5614 -4
+ Partials 2241 2238 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
piponazo
previously approved these changes
Feb 26, 2023
mergify
bot
dismissed
piponazo’s stale review
Pull request has been modified.
|
I'm unsure about coverity: add move operations Look sane? |
CID 1521171: Missing move assignment operator Signed-off-by: Rosen Penev <[email protected]>
Comment on lines
-523
to
-525
| if (newlength > std::numeric_limits<size_t>::max()) { | ||
| return {}; // Integer overflow. | ||
| } |
There was a problem hiding this comment.
Yes, this overflow check doesn't work. It needs to happen before the calculation of newlength! But this whole block of code could probably be replaced with strtoull or something similar.
neheb
force-pushed
the
mf
branch
2 times, most recently
from
18093c6
to
ce86e0c
Compare
same as getULongLong Signed-off-by: Rosen Penev <[email protected]>
Found with: CID 1521533 Unsigned compared against 0 (NO_EFFECT) Signed-off-by: Rosen Penev <[email protected]>
kevinbackhouse
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.