Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverity fixes #2513

Merged
merged 9 commits into from
Feb 25, 2023
Merged

coverity fixes #2513

merged 9 commits into from
Feb 25, 2023

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Feb 19, 2023

I added some builds to https://scan.coverity.com/projects/exiv2 and fixed several issues

@ghost
Copy link

ghost commented Feb 19, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #2513 (10289f8) into main (230fbaf) will decrease coverage by 0.02%.
The diff coverage is 43.28%.

@@            Coverage Diff             @@
##             main    #2513      +/-   ##
==========================================
- Coverage   64.66%   64.65%   -0.02%     
==========================================
  Files         103      103              
  Lines       22249    22232      -17     
  Branches    10859    10858       -1     
==========================================
- Hits        14388    14373      -15     
+ Misses       5620     5618       -2     
  Partials     2241     2241              
Impacted Files Coverage Δ
app/actions.cpp 67.91% <ø> (ø)
include/exiv2/asfvideo.hpp 66.66% <ø> (ø)
include/exiv2/image.hpp 100.00% <ø> (ø)
include/exiv2/matroskavideo.hpp 60.00% <0.00%> (+3.75%) ⬆️
include/exiv2/preview.hpp 100.00% <ø> (ø)
include/exiv2/riffvideo.hpp 100.00% <ø> (ø)
src/basicio.cpp 51.90% <ø> (ø)
src/http.cpp 0.00% <0.00%> (ø)
src/matroskavideo.cpp 4.52% <0.00%> (ø)
src/tiffcomposite_int.hpp 90.09% <ø> (-0.18%) ⬇️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Rosen Penev <[email protected]>
src/types.cpp Outdated Show resolved Hide resolved
src/types.cpp Outdated Show resolved Hide resolved
src/version.cpp Outdated Show resolved Hide resolved
Signed-off-by: Rosen Penev <[email protected]>
Signed-off-by: Rosen Penev <[email protected]>
Signed-off-by: Rosen Penev <[email protected]>
No need to deal with individual members

Signed-off-by: Rosen Penev <[email protected]>
Found with cppcoreguidelines-pro-type-member-init

Signed-off-by: Rosen Penev <[email protected]>
Signed-off-by: Rosen Penev <[email protected]>
Signed-off-by: Rosen Penev <[email protected]>
matches what is done elsewhere

Signed-off-by: Rosen Penev <[email protected]>
@neheb neheb merged commit 55d16ac into Exiv2:main Feb 25, 2023
@neheb neheb deleted the c branch February 25, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants