Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unitTests: fix old API usage #2498

Merged
merged 2 commits into from
Feb 13, 2023
Merged

unitTests: fix old API usage #2498

merged 2 commits into from
Feb 13, 2023

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Feb 7, 2023

Found with google-upgrade-googletest-case

Signed-off-by: Rosen Penev [email protected]

@ghost
Copy link

ghost commented Feb 7, 2023

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #2498 (c69ee64) into main (7e40da7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2498   +/-   ##
=======================================
  Coverage   62.04%   62.04%           
=======================================
  Files         102      102           
  Lines       22764    22764           
  Branches    11205    11205           
=======================================
  Hits        14124    14124           
  Misses       6433     6433           
  Partials     2207     2207           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@neheb
Copy link
Collaborator Author

neheb commented Feb 7, 2023

Any reason gtest 1.8.0 is being tested in CI?

No need for custom build.

Signed-off-by: Rosen Penev <[email protected]>
Found with google-upgrade-googletest-case

Signed-off-by: Rosen Penev <[email protected]>
@neheb neheb merged commit 785a9ed into Exiv2:main Feb 13, 2023
@neheb neheb deleted the gt branch February 13, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants