Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use __has_include #2485

Merged
merged 1 commit into from
Jan 29, 2023
Merged

use __has_include #2485

merged 1 commit into from
Jan 29, 2023

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Jan 29, 2023

Signed-off-by: Rosen Penev [email protected]

@ghost
Copy link

ghost commented Jan 29, 2023

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Merging #2485 (9ce8265) into main (3766382) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2485      +/-   ##
==========================================
+ Coverage   62.11%   62.12%   +0.01%     
==========================================
  Files         121      121              
  Lines       22820    22828       +8     
  Branches    11209    11209              
==========================================
+ Hits        14174    14182       +8     
  Misses       6439     6439              
  Partials     2207     2207              
Impacted Files Coverage Δ
app/actions.cpp 67.91% <ø> (ø)
src/basicio.cpp 51.67% <ø> (ø)
src/futils.cpp 75.29% <ø> (ø)
src/version.cpp 89.01% <ø> (+0.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Rosen Penev <[email protected]>
Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 💯 . I did not think until now that the usage of __has_include could make redundant the CMake configuration step in which we examine the system headers.

This is a very good post about the topic:
https://vector-of-bool.github.io/2020/10/04/lib-configuration.html

@neheb neheb merged commit d874fc4 into Exiv2:main Jan 29, 2023
@neheb neheb deleted the 4 branch January 29, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants