Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move inline to declaration #2480

Merged
merged 1 commit into from
Jan 29, 2023
Merged

move inline to declaration #2480

merged 1 commit into from
Jan 29, 2023

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Jan 27, 2023

Fixes warning under Windows:

redeclared inline; 'dllimport' attribute ignored [-Wignored-attributes]

Signed-off-by: Rosen Penev [email protected]

Fixes warning under Windows:

redeclared inline; 'dllimport' attribute ignored [-Wignored-attributes]

Signed-off-by: Rosen Penev <[email protected]>
@ghost
Copy link

ghost commented Jan 27, 2023

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #2480 (72ce119) into main (a7a9835) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2480   +/-   ##
=======================================
  Coverage   62.11%   62.11%           
=======================================
  Files         121      121           
  Lines       22820    22820           
  Branches    11209    11209           
=======================================
  Hits        14174    14174           
  Misses       6439     6439           
  Partials     2207     2207           
Impacted Files Coverage Δ
include/exiv2/xmp_exiv2.hpp 88.88% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@neheb neheb merged commit 805a1e5 into Exiv2:main Jan 29, 2023
@neheb neheb deleted the 2 branch January 29, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants