Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export QuickTimeVideo #2479

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Export QuickTimeVideo #2479

merged 1 commit into from
Jan 27, 2023

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented Jan 27, 2023

Explicitly export QuickTimeVideo, so it is exported on Windows/MSVC as well.

Also clean up/synchronize other video public headers

@ghost
Copy link

ghost commented Jan 27, 2023

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #2479 (4e8dca4) into main (a87c59b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2479   +/-   ##
=======================================
  Coverage   62.11%   62.11%           
=======================================
  Files         121      121           
  Lines       22819    22819           
  Branches    11209    11209           
=======================================
  Hits        14173    14173           
  Misses       6439     6439           
  Partials     2207     2207           
Impacted Files Coverage Δ
include/exiv2/matroskavideo.hpp 56.25% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kmilos kmilos merged commit c9f7a9f into main Jan 27, 2023
@mergify mergify bot deleted the export_qtvid branch January 27, 2023 14:34
@neheb
Copy link
Collaborator

neheb commented Jan 27, 2023

In meson I'm using visibility:hidden so it fixes it there too.

@kmilos
Copy link
Collaborator Author

kmilos commented Jan 27, 2023

In meson I'm using visibility:hidden so it fixes it there too.

I think recent CLang (from 14?) switched to hidden by default as well...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants