CI: inih now available for Cygwin #2468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2468 +/- ##
=======================================
Coverage 62.08% 62.08%
=======================================
Files 121 121
Lines 22830 22830
Branches 11212 11212
=======================================
Hits 14175 14175
Misses 6448 6448
Partials 2207 2207 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kmilos
force-pushed
the
ci_windows_inih
branch
from
808e6c2
to
84847a0
Compare
kevinbackhouse
previously approved these changes
Jan 18, 2023
kmilos
force-pushed
the
ci_windows_inih
branch
from
84847a0
to
5e0ac8d
Compare
mergify
bot
dismissed
kevinbackhouse’s stale review
Pull request has been modified.
|
Not sure about the failing test now, can't test locally unfortunately... Edit: Cygwin had -DBUILD_SAMPLES=OFF by default before. I could turn it off again, unless someone can shed some light on the |
kmilos
force-pushed
the
ci_windows_inih
branch
from
5e0ac8d
to
7ac96fc
Compare
kmilos
force-pushed
the
ci_windows_inih
branch
from
7ac96fc
to
fe327e1
Compare
kevinbackhouse
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you @me-and
Also w/ some cleanup to make MSYS2 and Cygwin jobs more similar.