-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exiv2 v0.27.6 #2463
Exiv2 v0.27.6 #2463
Conversation
Codecov Report
@@ Coverage Diff @@
## 0.27-maintenance #2463 +/- ##
====================================================
+ Coverage 58.89% 59.92% +1.02%
====================================================
Files 149 149
Lines 23203 23921 +718
Branches 12711 12664 -47
====================================================
+ Hits 13666 14334 +668
+ Misses 6700 6692 -8
- Partials 2837 2895 +58
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The failures in the macOS release build in CI are consistent and I haven't been able to reproduce them locally. Combo
Combo
Anyone know what's going on here? cc @postscript-dev, @kmilos, @piponazo, @neheb, @kevinbackhouse |
First time that I see this Mac CI errors. I could try to reproduce locally too, now that I have a Mac at home. I will let you know if I find the time to do it. |
I was able to reproduce the problem with |
af449c0
to
81bec86
Compare
This serves as a work around for a weird bug in Apple Clang 14.0.* xref: https://stackoverflow.com/q/75153729/1005215
81bec86
to
d2ed6f4
Compare
I remember converting this to std::array. vector seems better here because of the constructor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ❤️
Finally, I know this is a worn out subject, but should we perhaps make ENABLE_BMFF=ON the default for this release and on this branch as well? |
For a patch release, I'd rather not. But I'm open to cutting a minor release with that flip. |
@nehaljwani: nice work tracking down that macOS bug! Amazing that it's actually caused by a compiler bug! |
@nehaljwani One minor thing, would it be possible to change my contributor name from |
It is time to cut a release 🙂
xref: #2406