wmain: build as c++ instead of c #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to keep exiv2 c++ only. Signed-off-by: Rosen Penev <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #2453 +/- ##
=======================================
Coverage 62.10% 62.10%
=======================================
Files 122 122
Lines 22937 22937
Branches 11244 11244
=======================================
Hits 14245 14245
Misses 6475 6475
Partials 2217 2217 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
piponazo
approved these changes
Jan 4, 2023
|
|
||
| args = HeapAlloc(heap, 0, nbytes); | ||
| args[0] = (char*)(args + argc + 1); | ||
| args = reinterpret_cast<char**>(HeapAlloc(heap, 0, nbytes)); |
There was a problem hiding this comment.
[question] I am just curious about this. Was this producing some warnings with some compilers? Is this about a recommendation suggested by clang-tidy?
There was a problem hiding this comment.
The latter. Wonder why double pointer now...
There was a problem hiding this comment.
Ah nvm. The issue here is that C++ is stricter when it comes to pointers. eg, you always need to cast malloc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to keep exiv2 c++ only.
Signed-off-by: Rosen Penev [email protected]