Fix memory leak in BmffImage::brotliUncompress #2428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinbackhouse
added
bug
OSS-Fuzz
…l?id=52767 Add wrapper class to automatically call BrotliDecoderDestroyInstance() on exit.
kevinbackhouse
force-pushed
the
fix-issue-2427
branch
from
39280d7
to
2739d90
Compare
Codecov Report
@@ Coverage Diff @@
## main #2428 +/- ##
==========================================
+ Coverage 64.54% 64.64% +0.09%
==========================================
Files 119 119
Lines 21114 21119 +5
Branches 10421 10420 -1
==========================================
+ Hits 13629 13653 +24
+ Misses 5324 5300 -24
- Partials 2161 2166 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Thanks! |
kmilos
approved these changes
Nov 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2427
Add a wrapper class named
BrotliDecoderWrapperwhich automatically callsBrotliDecoderDestroyInstancein its destructor so that theBrotliDecoderStatewon't be leaked on exit.