Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid buffer reallocation #2392

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Avoid buffer reallocation #2392

merged 1 commit into from
Oct 25, 2022

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented Oct 25, 2022

The termination was there just for the default constructor...

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #2392 (406d7d7) into main (fb6b769) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2392   +/-   ##
=======================================
  Coverage   64.26%   64.26%           
=======================================
  Files         119      119           
  Lines       21138    21136    -2     
  Branches    10430    10428    -2     
=======================================
  Hits        13584    13584           
+ Misses       5403     5401    -2     
  Partials     2151     2151           
Impacted Files Coverage Δ
src/bmffimage.cpp 68.26% <0.00%> (+0.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kmilos kmilos merged commit 1f5bc3b into main Oct 25, 2022
@kmilos kmilos deleted the bmff_realloc_fix branch October 25, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants