Don't allow zero width/height in WebPImage::inject_VP8X #2348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2348 +/- ##
==========================================
+ Coverage 63.38% 63.52% +0.13%
==========================================
Files 119 119
Lines 20621 20623 +2
Branches 10231 10233 +2
==========================================
+ Hits 13071 13100 +29
+ Misses 5420 5394 -26
+ Partials 2130 2129 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
neheb
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2270
After reading the links mentioned in the source code (1, 2), I think the
+1and-1adjustments are correct. However, the code is assuming thatwidth > 0andheight > 0, which my poc (see #2270) proves isn't guaranteed to be true. Therefore, I think the best solution is to error out if the width or height is zero.