Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc sonarlint stuff #2336

Merged
merged 1 commit into from
Aug 23, 2022
Merged

misc sonarlint stuff #2336

merged 1 commit into from
Aug 23, 2022

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Aug 21, 2022

Signed-off-by: Rosen Penev [email protected]

Signed-off-by: Rosen Penev <[email protected]>
@codecov
Copy link

codecov bot commented Aug 21, 2022

Codecov Report

Merging #2336 (ff52314) into main (89d7798) will increase coverage by 0.00%.
The diff coverage is 36.36%.

@@           Coverage Diff           @@
##             main    #2336   +/-   ##
=======================================
  Coverage   63.47%   63.47%           
=======================================
  Files         118      118           
  Lines       19584    19593    +9     
  Branches     9569     9569           
=======================================
+ Hits        12431    12437    +6     
- Misses       5088     5092    +4     
+ Partials     2065     2064    -1     
Impacted Files Coverage Δ
app/getopt.cpp 59.18% <0.00%> (ø)
include/exiv2/bmffimage.hpp 100.00% <ø> (ø)
src/convert.cpp 51.40% <0.00%> (ø)
src/cr2header_int.hpp 33.33% <ø> (ø)
src/crwimage_int.hpp 92.85% <ø> (ø)
src/epsimage.cpp 1.76% <0.00%> (ø)
src/http.cpp 0.00% <0.00%> (ø)
src/makernote_int.hpp 92.30% <ø> (ø)
app/exiv2.cpp 62.54% <43.75%> (+0.05%) ⬆️
src/bmffimage.cpp 76.40% <50.00%> (-0.20%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@neheb neheb merged commit 71dc04e into Exiv2:main Aug 23, 2022
@neheb neheb deleted the 4 branch August 23, 2022 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants