-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Sony(1|2) tags #2323
Update Sony(1|2) tags #2323
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2323 +/- ##
==========================================
+ Coverage 63.51% 64.14% +0.62%
==========================================
Files 119 119
Lines 20634 21099 +465
Branches 10245 10425 +180
==========================================
+ Hits 13106 13534 +428
- Misses 5399 5408 +9
- Partials 2129 2157 +28
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
One tag in this PR that may be of interest to darktable developers is ExifTool's Sony LensSpec tag (0xb02a). This is set by compatible lenses and the translated output contains the focal length, aperture and some additional information (e.g., To test my PR, I have been using ExifTool's Sony JPEG samples which contain examples of the many different Sony camera types. This sample set includes lots of different lens examples. If I process the files with $ exiv2 -Pxkvt -K Exif.Sony1.LensID -K Exif.Sony1.LensSpec *.jpg 2>/dev/null > exiv2-LensID_LensSpec_tags.txt the exiv2-LensID_LensSpec_tags.txt file demonstrates the new tag. The file shows that I wasn't planning to backport everything in this PR but I am willing to work on the |
Recently it was decided that we can add lenses to exiv2 without a corroborating image, so I looked at adding the ExifTool Sony/Minolta lenses. I formatted the ExifTool lenses into an exiv2 array and can now see that there are lots of differences. As I don't have enough experience with lenses I don't plan to finish this task. If someone else wants to work on this, the formatted array is available in exiftool_SonyMinolta-lens-in-exiv2-format.txt. You can do a diff with the array in Lines 1027 to 1030 in 3ac7608
to find the problems. |
@postscript-dev: I made one final suggestion in postscript-dev#6 and then I am happy with the code changes. (I'm not qualified to comment on the tag changes because I don't know anything about cameras!) |
Transcribe all tags (except for `LensID`) from main ExifTool Sony group into Exiv2. Changes include: - Rename `ColorReproduction` -> `CreativeStyle` and `LongExposureNoiseReduction` -> `FocusMode3` to reflect use. - Rename `0x*` tagnames to equivalent ExifTool tags (e.g., `0x2006` -> `Sharpness`). - Remove tag entries that are Groups (e.g., `ShotInfo`). - Separate some common Sony/Minolta data as the camera types use different values (e.g., `Quality`) - Additional `exiv2-Sony*.exv` test files come from ExifTool Sony samples (https://exiftool.org/Sony.tar.gz). ExifTool Sony tags sources: https://www.exiftool.org/TagNames/Sony.html https://github.com/exiftool/exiftool/blob/1e17485cbb372a502e5b9d052d01303db735e6fa/lib/Image/ExifTool/Sony.pm
Make finding the Sony model more resilient by also using `SonyModelID`.
dc6ae50
to
0f00116
Compare
@kevinbackhouse: |
@kevinbackhouse |
Transcribe all tags (except for
LensID
) from main ExifTool Sony group into Exiv2.Changes include:
ColorReproduction
->CreativeStyle
andLongExposureNoiseReduction
->FocusMode3
to reflect use.0x*
tagnames to equivalent ExifTool tags (e.g.,0x2006
->Sharpness
)DynamicRangeOptimizer
(0xb04f) toDynamicRangeOptimizer2
)ShotInfo
).Quality
)exiv2-Sony*.exv
and someexiv2_pr2323-coverage*.exv
test files are from ExifTool Sony samples (https://exiftool.org/Sony.tar.gz).ExifTool Sony tags sources:
https://www.exiftool.org/TagNames/Sony.html
https://github.com/exiftool/exiftool/blob/1e17485cbb372a502e5b9d052d01303db735e6fa/lib/Image/ExifTool/Sony.pm