Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace structs with std::pair #2300

Merged
merged 1 commit into from
Aug 3, 2022
Merged

replace structs with std::pair #2300

merged 1 commit into from
Aug 3, 2022

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Aug 2, 2022

Simpler.

Signed-off-by: Rosen Penev [email protected]

Simpler.

Signed-off-by: Rosen Penev <[email protected]>
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #2300 (8b976f4) into main (ee5dae4) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #2300      +/-   ##
==========================================
- Coverage   63.53%   63.52%   -0.01%     
==========================================
  Files         118      118              
  Lines       19595    19590       -5     
  Branches     9576     9575       -1     
==========================================
- Hits        12450    12445       -5     
  Misses       5079     5079              
  Partials     2066     2066              
Impacted Files Coverage Δ
src/tiffimage_int.hpp 81.81% <ø> (-5.69%) ⬇️
src/tiffimage_int.cpp 78.34% <50.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@neheb neheb merged commit d5e42da into Exiv2:main Aug 3, 2022
@neheb neheb deleted the xnr branch August 3, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants