Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the return type of the 2Data functions to size_t #2281

Merged
merged 2 commits into from
Aug 1, 2022

Conversation

kevinbackhouse
Copy link
Collaborator

The 2Data functions (us2Data, ul2Data, ...) return the number of bytes written, so size_t is more appropriate than long.

@kevinbackhouse kevinbackhouse added this to the v1.00 milestone Jul 16, 2022
@codecov
Copy link

codecov bot commented Jul 16, 2022

Codecov Report

Merging #2281 (9430067) into main (39239ce) will increase coverage by 0.01%.
The diff coverage is 95.45%.

@@            Coverage Diff             @@
##             main    #2281      +/-   ##
==========================================
+ Coverage   63.52%   63.53%   +0.01%     
==========================================
  Files         118      118              
  Lines       19604    19595       -9     
  Branches     9584     9576       -8     
==========================================
- Hits        12453    12450       -3     
+ Misses       5086     5079       -7     
- Partials     2065     2066       +1     
Impacted Files Coverage Δ
include/exiv2/types.hpp 76.59% <ø> (ø)
src/tiffcomposite_int.cpp 75.60% <66.66%> (-0.33%) ⬇️
include/exiv2/value.hpp 84.51% <100.00%> (ø)
src/types.cpp 94.47% <100.00%> (ø)
src/xmpsidecar.cpp 64.28% <0.00%> (-0.37%) ⬇️
app/exiv2.cpp 62.48% <0.00%> (-0.20%) ⬇️
src/jp2image.cpp 70.19% <0.00%> (-0.07%) ⬇️
src/tiffvisitor_int.cpp 79.45% <0.00%> (-0.03%) ⬇️
src/casiomn_int.cpp 6.89% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39239ce...9430067. Read the comment docs.

@kevinbackhouse kevinbackhouse marked this pull request as draft July 17, 2022 15:28
piponazo
piponazo previously approved these changes Aug 1, 2022
Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot dismissed piponazo’s stale review August 1, 2022 12:33

Pull request has been modified.

@kevinbackhouse kevinbackhouse marked this pull request as ready for review August 1, 2022 12:54
@neheb neheb merged commit ee5dae4 into Exiv2:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants