Update olympus tags (#2246) #2249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Enable `ArtFilter` translations to be used in more situations. This is consistent with the equivalent ExifTool tags. + Add user color choice to `Partial Color` output. + Add `( )` around output of values that cannot be translated. + Add testing.
`Exif.OlympusCs.ImageStabilization` - Change type from `unsignedShort` to `unsignedLong` (ExifTool) - Add extra `On, Mode 4` translated output (ExifTool) - Add specific translated output for E-M10 Mark II camera `Exif.OlympusCs.WhiteBalance` - Add missing `)` to translated output Cf: [Exiftool Olympus tags](https://www.exiftool.org/TagNames/Olympus.html).
postscript-dev
added
the
prettyPrinter
Codecov Report
@@ Coverage Diff @@
## main #2249 +/- ##
==========================================
+ Coverage 63.52% 63.54% +0.02%
==========================================
Files 118 118
Lines 19600 19601 +1
Branches 9560 9559 -1
==========================================
+ Hits 12450 12456 +6
+ Misses 5082 5080 -2
+ Partials 2068 2065 -3
Continue to review full report at Codecov.
|
kmilos
reviewed
Jun 15, 2022
kmilos
approved these changes
Jul 19, 2022
kmilos
added
the
makerNote
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update translation output of
Exif.OlympusCs.ArtFilter/Exif.OlympusCs.MagicFilter,Exif.OlympusCs.ImageStabilizationandExif.OlympusCs.WhiteBalancetags.Fix
Exif.OlympusCs.ImageStabilizationtype fromunsignedShorttounsignedLong.Ref: Exiftool Olympus tags and Olympus E-M10 Mark II instuction manual.
Closes #2246.