Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some F mount lenses #2215

Merged
merged 1 commit into from
May 21, 2022
Merged

Add some F mount lenses #2215

merged 1 commit into from
May 21, 2022

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented Apr 20, 2022

Address #2193, #2196 and #2214

@kmilos kmilos requested a review from hassec April 20, 2022 09:53
@kmilos
Copy link
Collaborator Author

kmilos commented Apr 20, 2022

Not 100% sure for the Tamron string - I followed the pattern of existing Tamrons in the exiv2 Nikon database, but it is included in lensfun under a slightly different name (Canon/exiftool style?) already... @tuxfanx

This situation w/ 3rd party lens identification across different mounts really 👃 💩

@kmilos kmilos added the lens Issue related to lens detection label Apr 20, 2022
@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #2215 (707e22c) into main (6438305) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2215   +/-   ##
=======================================
  Coverage   63.30%   63.30%           
=======================================
  Files         116      116           
  Lines       19599    19599           
  Branches     9545     9545           
=======================================
  Hits        12407    12407           
  Misses       5117     5117           
  Partials     2075     2075           
Impacted Files Coverage Δ
src/nikonmn_int.cpp 57.10% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6438305...707e22c. Read the comment docs.

@kmilos
Copy link
Collaborator Author

kmilos commented Apr 20, 2022

Actually, one should drop "AF" from the modern OSD Tamrons, so this might just work out...

@tuxfanx Can you please confirm this will be matched by lensfun now?

@tuxfanx
Copy link

tuxfanx commented Apr 20, 2022

Not 100% sure for the Tamron string - I followed the pattern of existing Tamrons in the exiv2 Nikon database, but it is included in lensfun under a slightly different name (Canon/exiftool style?) already... @tuxfanx

for the canon mount, exiv2 outputs the following:
Exif.Photo.LensSpecification Rational 4 35/1 150/1 0/0 0/0
Exif.Photo.LensModel Ascii 41 TAMRON 35-150mm F/2.8-4.0 Di VC OSD A043
Exif.Photo.LensSerialNumber Ascii 11 0000000000
Exif.Image.LensInfo Rational 4 35/1 150/1 0/0 0/0
you can find some raw pictures taken with the canon mount lens here

In my opinion, the "AF" does not belong in the model designation because Tamron does not use the "AF" either. If AF is used, it should also be included in the manufacturer's model number.
When using the "AF", 2 separate entries would also have to be listed in the Lensfun DB because of the different canon model designation.

@tuxfanx
Copy link

tuxfanx commented Apr 20, 2022

Actually, one should drop "AF" from the modern OSD Tamrons, so this might just work out...

@tuxfanx Can you please confirm this will be matched by lensfun now?

"35-150mm F/2.8-4 Di VC OSD" would work, but is it necessary that the entry for Nikon is different from the entry for Canon?

@kmilos
Copy link
Collaborator Author

kmilos commented Apr 20, 2022

"35-150mm F/2.8-4 Di VC OSD" would work, but is it necessary that the entry for Nikon is different from the entry for Canon?

Thanks for checking.

One could ask the opposite just as well. It's all a bit arbitrary, isn't it?

I'd prefer to keep the Nikon (or any other vendor) database scheme self-consistent (how/why we got to different naming schemes is beyond me). I can also happily remove the Tamron from this PR and let someone else handle it, or just leave users put whatever string they prefer in their ~/.exiv2 config file.

@kmilos kmilos merged commit 93dc63b into main May 21, 2022
@kmilos kmilos deleted the add_f_lenses branch May 21, 2022 14:13
@kmilos
Copy link
Collaborator Author

kmilos commented May 21, 2022

@Mergifyio backport 0.27-maintenance

@mergify
Copy link
Contributor

mergify bot commented May 21, 2022

backport 0.27-maintenance

✅ Backports have been created

kmilos added a commit that referenced this pull request May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lens Issue related to lens detection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants