-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some F mount lenses #2215
Add some F mount lenses #2215
Conversation
Not 100% sure for the Tamron string - I followed the pattern of existing Tamrons in the exiv2 Nikon database, but it is included in lensfun under a slightly different name (Canon/exiftool style?) already... @tuxfanx This situation w/ 3rd party lens identification across different mounts really 👃 💩 |
Codecov Report
@@ Coverage Diff @@
## main #2215 +/- ##
=======================================
Coverage 63.30% 63.30%
=======================================
Files 116 116
Lines 19599 19599
Branches 9545 9545
=======================================
Hits 12407 12407
Misses 5117 5117
Partials 2075 2075
Continue to review full report at Codecov.
|
Actually, one should drop "AF" from the modern OSD Tamrons, so this might just work out... @tuxfanx Can you please confirm this will be matched by lensfun now? |
for the canon mount, exiv2 outputs the following: In my opinion, the "AF" does not belong in the model designation because Tamron does not use the "AF" either. If AF is used, it should also be included in the manufacturer's model number. |
"35-150mm F/2.8-4 Di VC OSD" would work, but is it necessary that the entry for Nikon is different from the entry for Canon? |
Thanks for checking. One could ask the opposite just as well. It's all a bit arbitrary, isn't it? I'd prefer to keep the Nikon (or any other vendor) database scheme self-consistent (how/why we got to different naming schemes is beyond me). I can also happily remove the Tamron from this PR and let someone else handle it, or just leave users put whatever string they prefer in their ~/.exiv2 config file. |
@Mergifyio backport 0.27-maintenance |
✅ Backports have been created
|
Add some F mount lenses (backport #2215)
Address #2193, #2196 and #2214