mostly nodiscard

[neheb]

No description provided.

[codecov]

Codecov Report

Merging #2175 (c0868af) into main (9cad8ce) will increase coverage by 0.00%.
The diff coverage is 98.38%.

@@           Coverage Diff           @@
##             main    #2175   +/-   ##
=======================================
  Coverage   63.29%   63.29%           
=======================================
  Files          98       99    +1     
  Lines       19568    19569    +1     
  Branches     9551     9554    +3     
=======================================
+ Hits        12385    12386    +1     
  Misses       5112     5112           
  Partials     2071     2071           

Impacted Files	Coverage Δ
include/exiv2/basicio.hpp	100.00% <ø> (ø)
include/exiv2/datasets.hpp	100.00% <ø> (ø)
include/exiv2/error.hpp	47.05% <ø> (ø)
include/exiv2/metadatum.hpp	75.00% <ø> (ø)
include/exiv2/properties.hpp	100.00% <ø> (ø)
include/exiv2/tags.hpp	100.00% <ø> (ø)
src/cr2header_int.hpp	33.33% <ø> (ø)
src/makernote_int.hpp	91.66% <ø> (ø)
src/orfimage_int.hpp	100.00% <ø> (ø)
src/rw2image_int.hpp	100.00% <ø> (ø)
... and 14 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 081dfbd...c0868af. Read the comment docs.

[piponazo]

LGTM! 👏 It is surprising to me that the addition of [[nodiscard]] only impacted 2 .cpp files.