Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip XMP raw packet before decoding (backport #2133) #2139

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented Mar 10, 2022

(cherry picked from commit eb49d66)

@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #2139 (f1c657c) into 0.27-maintenance (d70e575) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           0.27-maintenance    #2139      +/-   ##
====================================================
- Coverage             58.72%   58.72%   -0.01%     
====================================================
  Files                   146      146              
  Lines                 23003    23005       +2     
  Branches              12596    12597       +1     
====================================================
+ Hits                  13508    13509       +1     
  Misses                 6692     6692              
- Partials               2803     2804       +1     
Impacted Files Coverage Δ
src/xmp.cpp 77.30% <75.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d70e575...f1c657c. Read the comment docs.

@kmilos kmilos added the bug label Mar 10, 2022
@kmilos kmilos added this to the v0.27.6 milestone Mar 10, 2022
@kmilos kmilos changed the title Strip XMP raw packet before decoding Strip XMP raw packet before decoding (backport #2133) Mar 10, 2022
@piponazo
Copy link
Collaborator

Hum, there are some jobs failing here ... I wonder if the CI configuration has changed a lot between main and 0.27. Give me some time (days) to take a look there and check the status of CI on 0.27. Probably with some minor effort I can bring it back to a normal state.

@kmilos
Copy link
Collaborator Author

kmilos commented Mar 10, 2022

Yeah, only the Windows jobs fail, seems to be conan related, again 😕

@clanmills
Copy link
Collaborator

Let me look at this. I confess that I like Windows. Visual Studio + MFC are awesome. Well, in the 90s they were. I haven't used them for 20 years.

I'm gonna buy a Mac Studio with the M1-Max (the less expensive version).

@piponazo
Copy link
Collaborator

@clanmills I am already working at it. I hope that by updating the CI workflows with the latest changes done in main I can solve the situation easily.

@piponazo
Copy link
Collaborator

@kmilos try to rebase your branch and hopefully the CI will turn green after we merged #2140

(cherry picked from commit eb49d66)
Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kmilos kmilos merged commit 44ef6ae into 0.27-maintenance Mar 10, 2022
@kmilos kmilos deleted the bp_pr2133 branch March 10, 2022 19:39
@clanmills
Copy link
Collaborator

Thank You: @kmilos and @piponazo.

antermin pushed a commit to antermin/exiv2 that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants