-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conversions to make_unique #2129
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2129 +/- ##
=======================================
Coverage 63.35% 63.35%
=======================================
Files 97 97
Lines 19175 19175
Branches 9712 9712
=======================================
Hits 12149 12149
Misses 4758 4758
Partials 2268 2268
Continue to review full report at Codecov.
|
0b02e1f
to
65cede8
Compare
I cannot explain why but I tried to run this locally and it is also failing on my Windows setup. |
seems to be some type problem. No clue. |
7f3b696
to
31321cb
Compare
Early speculation: the MSVC 7.1 bug comment might be a hint as to what's going wrong. I notice only one of the TiffBinaryArray functions uses it. |
Signed-off-by: Rosen Penev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is happy now 👍
Yeah. TiffBinaryArray can be handled later. |
Signed-off-by: Rosen Penev [email protected]