Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mostly clang-tidy cleanups #2124

Merged
merged 11 commits into from
Mar 5, 2022
Merged

mostly clang-tidy cleanups #2124

merged 11 commits into from
Mar 5, 2022

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented Mar 4, 2022

No description provided.

@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #2124 (a8c8918) into main (b17828b) will decrease coverage by 0.02%.
The diff coverage is 65.51%.

❗ Current head a8c8918 differs from pull request most recent head a25bbe1. Consider uploading reports for the commit a25bbe1 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2124      +/-   ##
==========================================
- Coverage   63.41%   63.39%   -0.03%     
==========================================
  Files          97       97              
  Lines       19187    19190       +3     
  Branches     9721     9713       -8     
==========================================
- Hits        12168    12165       -3     
- Misses       4752     4756       +4     
- Partials     2267     2269       +2     
Impacted Files Coverage Δ
include/exiv2/basicio.hpp 100.00% <ø> (ø)
src/casiomn_int.cpp 7.14% <0.00%> (ø)
src/cr2header_int.cpp 69.44% <ø> (ø)
src/epsimage.cpp 1.83% <0.00%> (ø)
src/exif.cpp 65.80% <0.00%> (-0.22%) ⬇️
src/fujimn_int.cpp 100.00% <ø> (ø)
src/http.cpp 0.00% <0.00%> (ø)
src/minoltamn_int.cpp 54.34% <ø> (ø)
src/nikonmn_int.cpp 58.73% <0.00%> (ø)
src/orfimage_int.cpp 33.33% <ø> (ø)
... and 125 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b17828b...a25bbe1. Read the comment docs.

Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I just made some minor comments here and there, but most of the changes look good to me 😉

src/basicio.cpp Show resolved Hide resolved
src/jpgimage.cpp Show resolved Hide resolved
src/preview.cpp Outdated Show resolved Hide resolved
src/canonmn_int.cpp Outdated Show resolved Hide resolved
@neheb
Copy link
Collaborator Author

neheb commented Mar 4, 2022

That should be it.

@piponazo piponazo self-requested a review March 5, 2022 08:56
Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@piponazo piponazo merged commit 88b1c96 into Exiv2:main Mar 5, 2022
@neheb neheb deleted the 1 branch March 5, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants