Catch std::exception in iptcprint #2111
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
main
function in theiptcprint
sample program catchesExiv2::AnyError
but notstd::exception
. The poc attached to #2050 is a bogus image file that triggers astd::overflow_error
in this call toSafe::add()
:exiv2/src/rafimage.cpp
Line 308 in 0b17cc3
In the exiv2 application, we catch those exceptions and print an error message. We just need to do the same in this sample application.
I also changed the error return code to
1
, because-1
is non-standard.