Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix branch names in CONTRIBUTING.md (master was renamed to main) #2070

Merged
merged 1 commit into from
Feb 5, 2022

Conversation

Sturmflut
Copy link
Contributor

No description provided.

Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing these notes (and for all your new contributions 👍 )

@codecov
Copy link

codecov bot commented Feb 5, 2022

Codecov Report

Merging #2070 (68ccc2c) into main (ed09d9f) will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2070      +/-   ##
==========================================
- Coverage   62.04%   61.83%   -0.22%     
==========================================
  Files          96       96              
  Lines       19194    19100      -94     
  Branches     9833     9817      -16     
==========================================
- Hits        11909    11810      -99     
- Misses       4978     4995      +17     
+ Partials     2307     2295      -12     
Impacted Files Coverage Δ
src/safe_op.hpp 69.23% <0.00%> (-27.65%) ⬇️
include/exiv2/slice.hpp 69.64% <0.00%> (-21.89%) ⬇️
include/exiv2/error.hpp 60.71% <0.00%> (-4.81%) ⬇️
src/utils.cpp 38.46% <0.00%> (-1.93%) ⬇️
include/exiv2/value.hpp 82.96% <0.00%> (-0.55%) ⬇️
src/enforce.hpp 75.00% <0.00%> (+2.77%) ⬆️
src/getopt.cpp 67.30% <0.00%> (+5.76%) ⬆️
include/exiv2/metadatum.hpp 88.88% <0.00%> (+16.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed09d9f...68ccc2c. Read the comment docs.

@piponazo piponazo merged commit 2714d27 into Exiv2:main Feb 5, 2022
@postscript-dev
Copy link
Collaborator

@Sturmflut: Thanks for contributing this.

If you have the time, would you be interested in also updating GIT_GUIDELINES.md? This has the same master/main problem.

@Sturmflut Sturmflut deleted the fix-contributing-md branch February 5, 2022 17:32
@Sturmflut
Copy link
Contributor Author

@Sturmflut: Thanks for contributing this.

If you have the time, would you be interested in also updating GIT_GUIDELINES.md? This has the same master/main problem.

Sure, see #2075.

@postscript-dev
Copy link
Collaborator

@Sturmflut: Great, thanks for working on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants