Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more DNG 1.6 tags #2023

Merged
merged 2 commits into from
Dec 11, 2021
Merged

Add more DNG 1.6 tags #2023

merged 2 commits into from
Dec 11, 2021

Conversation

kmilos
Copy link
Collaborator

@kmilos kmilos commented Dec 10, 2021

Add a couple of more DNG 1.6 tags since the last update from https://helpx.adobe.com/photoshop/kb/dng-specification-tags.html (seems like it's a living, not yet finalized/published spec)

@codecov
Copy link

codecov bot commented Dec 10, 2021

Codecov Report

Merging #2023 (22e4baf) into main (1b53303) will not change coverage.
The diff coverage is n/a.

❗ Current head 22e4baf differs from pull request most recent head 66b1eaa. Consider uploading reports for the commit 66b1eaa to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2023   +/-   ##
=======================================
  Coverage   61.36%   61.36%           
=======================================
  Files          96       96           
  Lines       19248    19248           
  Branches     9858     9858           
=======================================
  Hits        11811    11811           
  Misses       5101     5101           
  Partials     2336     2336           
Impacted Files Coverage Δ
src/tags_int.cpp 77.05% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b53303...66b1eaa. Read the comment docs.

@piponazo
Copy link
Collaborator

I noticed that in tags_int.cpp there is a comment pointing to some dead resource:

   http://wwwimages.adobe.com/content/dam/Adobe/en/devnet/cinemadng/pdfs/CinemaDNG_Format_Specification_v1_1.pdf

Probably it would make sense to introduce a comment in that file with the link you shared here, so that people can access to more information about DNG tags.

@kmilos
Copy link
Collaborator Author

kmilos commented Dec 10, 2021

Do you prefer we added all the DNG related resources to the source file?

Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding the comments. It will be useful for newbies like me 🤓

@kmilos kmilos merged commit fd84471 into main Dec 11, 2021
@mergify mergify bot deleted the tags_update_dng16 branch December 11, 2021 08:30
@kmilos kmilos added the enhancement feature / functionality enhancements label Dec 11, 2021
@kmilos kmilos added this to the v1.00 milestone Dec 11, 2021
@kmilos kmilos mentioned this pull request Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature / functionality enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants