Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Conan from MacOS build #1986

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

kevinbackhouse
Copy link
Collaborator

Conan on macOS is not working (see #1976, #1980). It's probably related to the switch to macOS-11 in GitHub Actions, but I have no idea how to fix it. On the 0.27-maintenance branch, we don't use Conan on macOS, so maybe it would be easier to do the same on main.

@kevinbackhouse kevinbackhouse marked this pull request as draft October 24, 2021 13:55
@codecov
Copy link

codecov bot commented Oct 24, 2021

Codecov Report

Merging #1986 (e87e440) into main (c5101e0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1986   +/-   ##
=======================================
  Coverage   61.26%   61.26%           
=======================================
  Files          96       96           
  Lines       19105    19105           
  Branches     9756     9756           
=======================================
  Hits        11705    11705           
  Misses       5079     5079           
  Partials     2321     2321           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5101e0...e87e440. Read the comment docs.

Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it looks fine to remove the usage of conan for Mac. Somehow, it seems that the Mac images used by Github Action has already all the conan dependencies installed by default (Except gtest that you are handling with the new changes):

Found ZLIB: /Applications/Xcode_13.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk/usr/lib/libz.tbd (found version "1.2.11") 
-- Found CURL: /Applications/Xcode_13.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk/usr/lib/libcurl.tbd (found version "7.64.1")  
-- Found EXPAT: /Applications/Xcode_13.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk/usr/lib/libexpat.tbd (found version "2.2.8") 
-- Performing Test Iconv_IS_BUILT_IN
-- Performing Test Iconv_IS_BUILT_IN - Failed
-- Found Iconv: /Applications/Xcode_13.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk/usr/lib/libiconv.tbd  
-- ICONV_INCLUDE_DIR : /Applications/Xcode_13.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk/usr/include
-- ICONV_LIBRARIES : /Applications/Xcode_13.0.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.3.sdk/usr/lib/libiconv.tbd

Green light from my side 👍

@kevinbackhouse
Copy link
Collaborator Author

@piponazo: Thanks! Yes, I think the Github Action's VMs have a lot of developer tools pre-installed. I copied that gtest installation code from the 0.27-maintenance branch. And before that, I copied it from somewhere else, but I don't remember where!

@kevinbackhouse kevinbackhouse merged commit 76a9377 into Exiv2:main Oct 25, 2021
@kevinbackhouse kevinbackhouse added this to the v1.00 milestone Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants