Use std::move to transfer ownership of DataBufs. #1956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1956 +/- ##
=======================================
Coverage 61.12% 61.12%
=======================================
Files 96 96
Lines 19055 19054 -1
Branches 9743 9732 -11
=======================================
Hits 11647 11647
- Misses 5092 5094 +2
+ Partials 2316 2313 -3
Continue to review full report at Codecov.
|
|
No copy assignment operator is defined. I would define it as deleted l. |
kevinbackhouse
commented
Oct 11, 2021
| DataBuf& operator=(DataBuf&& rhs); | ||
|
|
||
| // No copy assignment. | ||
| DataBuf& operator=(const DataBuf&) = delete; |
neheb
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataBufhad a constructor that was used as a move constructor, but didn't have the correct type. This fixes that and changes the code to usestd::movewhen transferring ownership of aDataBuf.I also removed
DataBufRef, because it is no longer used.Everything here should be behavior preserving, except for the change that I made to this code in
image.cpp:exiv2/src/image.cpp
Lines 593 to 595 in 4901c5d
That looks like a bug to me because it's not copying the icc profile from
imageunlike all the copy operations in that function. Also, the condition&& iccProfile()could never fail, becauseiccProfilereturned a pointer to theiccProfile_field, so it could never be null. So I've changed that code to something that I think makes more sense. Unfortunately, we don't have any test coverage for it, so I don't know if I have broken anything with that change.