Add custom update-pot target #1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on a separate localization bug, I noticed that `po/exiv2.pot` hasn't been updated since 2017, and that with the removal of the autotools build system there's no longer any way to update it. Add a simple `update-pot` target to do so, and bring `po/POTFILES.in` up to date with the current source tree. I haven't updated `po/exiv2.pot` itself because that would be a large diff, though I've checked that the output looks reasonable. I suggest that maintainers do this.
Codecov Report
@@ Coverage Diff @@
## main #1907 +/- ##
==========================================
+ Coverage 60.87% 61.13% +0.26%
==========================================
Files 96 96
Lines 19041 19051 +10
Branches 9726 9729 +3
==========================================
+ Hits 11591 11647 +56
+ Misses 5138 5090 -48
- Partials 2312 2314 +2
Continue to review full report at Codecov.
|
|
@cjwatson: Thanks for this! I don't know anything about pot files, so please can you confirm that this is what you recommend we do: mkdir build
cd build
cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_SHARED_LIBS=ON -DEXIV2_ENABLE_PNG=ON -DEXIV2_ENABLE_WEBREADY=ON -DEXIV2_ENABLE_CURL=ON -DEXIV2_BUILD_UNIT_TESTS=ON -DEXIV2_ENABLE_BMFF=ON -DEXIV2_TEAM_WARNINGS_AS_ERRORS=ON -DEXIV2_ENABLE_NLS=ON ..
make
make update-potThen check in the updated version of |
kevinbackhouse
added a commit
to kevinbackhouse/exiv2
that referenced
this pull request
Sep 18, 2021
Closed
Update copyright and bug-address
|
@kevinbackhouse Yes, that all seems about right. (It probably doesn't need most of those options, though at least |
kevinbackhouse
approved these changes
Sep 24, 2021
kevinbackhouse
added a commit
to kevinbackhouse/exiv2
that referenced
this pull request
Sep 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on a separate localization bug, I noticed that
po/exiv2.pothasn't been updated since 2017, and that with the removalof the autotools build system there's no longer any way to update it.
Add a simple
update-pottarget to do so, and bringpo/POTFILES.inupto date with the current source tree.
I haven't updated
po/exiv2.potitself because that would be a largediff, though I've checked that the output looks reasonable. I suggest
that maintainers do this.