Add fuzzing dictionary and test all printStructure() options #1804
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1804 +/- ##
=======================================
Coverage 67.86% 67.86%
=======================================
Files 151 151
Lines 20847 20844 -3
=======================================
- Hits 14147 14146 -1
+ Misses 6700 6698 -2
Continue to review full report at Codecov.
|
| @@ -27,6 +27,11 @@ extern "C" int LLVMFuzzerTestOneInput(const uint8_t * data, size_t size) { | |||
| // produce lots of garbage on stdout. | |||
| std::ostringstream buffer; | |||
| image->printStructure(buffer, Exiv2::kpsNone); | |||
There was a problem hiding this comment.
line 24, seems to not do anything. exifData() just returns a reference to the container holding the exif metadata.
Do you think it would be helpful to the printing of the actual metadata values here as well?
That would cover all the functions we use to convert various raw metadata into their respective string representation.
Unfortunately, this isn't directly implemented in the image class, but in printMetadata() in actions.cpp.
But we could implement something similar relatively easily here since we don't need to worry about options and could just print every single metadatum we find.
There was a problem hiding this comment.
Good catch. It was in the original version of this fuzzer and I kept it because I didn't realize that it doesn't do anything. I have removed it now.
Two changes to the fuzzer to make it more comprehensive:
printStructureusing all the available options, such askpsXMPandkpsRecursive.The dictionary is checked in as a text file, but I have also included the scripts that I used to generate it, with a README explaining how to run them. The dictionary isn't very big, and doesn't need to be updated very often, so it's much more convenient to add it to the repo.