Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add Sigma 30mm f/1.4 DC DN | C to canon lens detection #1784

Merged
merged 2 commits into from
Jul 25, 2021
Merged

fix: add Sigma 30mm f/1.4 DC DN | C to canon lens detection #1784

merged 2 commits into from
Jul 25, 2021

Conversation

hassec
Copy link
Member

@hassec hassec commented Jul 16, 2021 •
edited
Loading

closes #1782

@hassec hassec added the lens Issue related to lens detection label Jul 16, 2021
@codecov
Copy link

codecov bot commented Jul 16, 2021 •
edited
Loading

Codecov Report

Merging #1784 (c420eb2) into main (8f126c0) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1784      +/-   ##
==========================================
+ Coverage   67.48%   67.49%   +0.01%     
==========================================
  Files         151      151              
  Lines       20805    20815      +10     
==========================================
+ Hits        14041    14050       +9     
- Misses       6764     6765       +1
Impacted Files Coverage Δ
src/canonmn_int.cpp 74.61% <ø> (ø)
src/image.cpp 72.91% <0.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f126c0...c420eb2. Read the comment docs.

@hassec hassec mentioned this pull request Jul 16, 2021
Closed
@hassec hassec merged commit 2944af7 into main Jul 25, 2021
@mergify mergify bot deleted the isssue1782 branch July 25, 2021 14:58
@postscript-dev postscript-dev mentioned this pull request Apr 28, 2022
Merged
@nehaljwani nehaljwani mentioned this pull request May 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinbackhouse kevinbackhouse kevinbackhouse approved these changes

Assignees
No one assigned
Labels
lens Issue related to lens detection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Canon CR3 format: Sigma 30 mm F1.4 DC DN (EFM) wrongly identified
2 participants
@hassec @kevinbackhouse