clang-tidy: pass by value #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1712 +/- ##
=======================================
Coverage 66.85% 66.85%
=======================================
Files 151 151
Lines 20729 20729
=======================================
Hits 13858 13858
Misses 6871 6871
Continue to review full report at Codecov.
|
hassec
reviewed
Jun 21, 2021
Comment on lines
+400
to
+402
| Key(std::string m, uint32_t e, IfdId g) : m_(std::move(m)), e_(e), g_(g) | ||
| { | ||
| } |
There was a problem hiding this comment.
Suggested change
| Key(std::string m, uint32_t e, IfdId g) : m_(std::move(m)), e_(e), g_(g) | |
| { | |
| } | |
| Key(std::string m, uint32_t e, IfdId g) : m_(std::move(m)), e_(e), g_(g){} |
There was a problem hiding this comment.
git clang-format is what sets it to this.
Found with modernize-pass-by-value Signed-off-by: Rosen Penev <[email protected]>
hassec
approved these changes
Jun 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found with modernize-pass-by-value
Signed-off-by: Rosen Penev [email protected]