Ci fix python requirement #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the CI-Linux-Distros jobs failed because of this. Python3 is not available by default on Debian:9 nor in Centos:8. Since we are not currently running the tests in those platforms, and python3 is just used for testing, we do not want to enforce this project dependency.
Codecov Report
@@ Coverage Diff @@
## main #1662 +/- ##
=======================================
Coverage 66.92% 66.92%
=======================================
Files 151 151
Lines 20775 20775
=======================================
Hits 13904 13904
Misses 6871 6871 Continue to review full report at Codecov.
|
kmilos
reviewed
May 18, 2021
kevinbackhouse
previously approved these changes
May 18, 2021
piponazo
force-pushed
the
ciFixPythonRequirement
branch
from
aa75643
to
5ba5846
Compare
kmilos
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that some of the CI-Linux-Distros jobs failed tonight due to a recent addition on the CMake code (requirement to find Python3 in order to run the python tests):
https://github.com/Exiv2/exiv2/actions/runs/852058640
I did not think that some platforms would not have Python3 installed by default. Since we are not currently running the tests in those CI-jobs, and python3 is just only used for testing, we do not want to enforce this project dependency.
Additionally I replaced the docker containers debian:9 with debian:10 (Since we want to test the latest versions of each platform).
I triggered again those CI-Linux-Distros jobs and with these changes, the CI looks green:
https://github.com/Exiv2/exiv2/actions/runs/852314993