Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quadratic complexity performance bug (backport #1657) #1658

Merged
merged 1 commit into from
May 16, 2021

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 16, 2021

This is an automatic backport of pull request #1657 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

@codecov
Copy link

codecov bot commented May 16, 2021

Codecov Report

Merging #1658 (c1d1fc4) into main (bf290e8) will increase coverage by 0.01%.
The diff coverage is 57.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1658      +/-   ##
==========================================
+ Coverage   66.90%   66.92%   +0.01%     
==========================================
  Files         151      151              
  Lines       20808    20807       -1     
==========================================
+ Hits        13922    13925       +3     
+ Misses       6886     6882       -4     
Impacted Files Coverage Δ
include/exiv2/pgfimage.hpp 100.00% <ø> (ø)
samples/Jzon.cpp 34.05% <0.00%> (ø)
src/bmpimage.cpp 25.00% <ø> (ø)
src/casiomn_int.cpp 7.14% <ø> (ø)
src/convert.cpp 69.06% <0.00%> (ø)
src/cr2header_int.cpp 77.14% <ø> (ø)
src/crwimage_int.cpp 87.31% <ø> (ø)
src/epsimage.cpp 2.00% <0.00%> (ø)
src/error.cpp 89.74% <ø> (ø)
src/exif.cpp 76.26% <ø> (ø)
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c73dfa0...c1d1fc4. Read the comment docs.

Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github Actions are not working well today. Let's way until is back to determine if the CI jobs pass.

@piponazo piponazo merged commit ee3b8d1 into main May 16, 2021
@mergify mergify bot deleted the mergify/bp/main/pr-1657 branch May 16, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants