Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-tidy: don't use else after return #1651

Merged
merged 1 commit into from
May 15, 2021
Merged

clang-tidy: don't use else after return #1651

merged 1 commit into from
May 15, 2021

Conversation

neheb
Copy link
Collaborator

@neheb neheb commented May 15, 2021

Found with llvm-else-after-return

Signed-off-by: Rosen Penev [email protected]

Found with llvm-else-after-return

Signed-off-by: Rosen Penev <[email protected]>
@codecov
Copy link

codecov bot commented May 15, 2021

Codecov Report

Merging #1651 (2776532) into main (b789c34) will decrease coverage by 0.01%.
The diff coverage is 42.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1651      +/-   ##
==========================================
- Coverage   66.90%   66.88%   -0.02%     
==========================================
  Files         151      151              
  Lines       20809    20803       -6     
==========================================
- Hits        13922    13915       -7     
- Misses       6887     6888       +1     
Impacted Files Coverage Δ
src/convert.cpp 69.06% <0.00%> (ø)
src/epsimage.cpp 2.00% <0.00%> (ø)
src/futils.cpp 87.27% <0.00%> (ø)
src/ini.cpp 7.54% <0.00%> (ø)
src/makernote_int.cpp 79.64% <0.00%> (-0.21%) ⬇️
src/nikonmn_int.cpp 52.91% <0.00%> (ø)
src/olympusmn_int.cpp 21.00% <0.00%> (ø)
src/panasonicmn_int.cpp 44.79% <0.00%> (ø)
src/preview.cpp 57.77% <0.00%> (ø)
src/tiffvisitor_int.cpp 87.41% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b789c34...2776532. Read the comment docs.

Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@piponazo piponazo merged commit fdf9d37 into Exiv2:main May 15, 2021
@neheb neheb deleted the val branch May 15, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants