Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

READMEs: Add whitespace around atx-style headers #1605

Merged
merged 1 commit into from
May 11, 2021
Merged

READMEs: Add whitespace around atx-style headers #1605

merged 1 commit into from
May 11, 2021

Conversation

jwilk
Copy link
Contributor

@jwilk jwilk commented May 7, 2021

The extra whitespace is necessary for GitHub to render the headers correctly.

The extra whitespace is necessary for GitHub to render the headers
correctly.
@piponazo piponazo self-requested a review May 9, 2021 13:14
Copy link
Collaborator

@piponazo piponazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jwilk , thanks for the contribution. Would you mind to add some screenshots showing what you are referring to? I compared the github rendering on our main branch and yours, and I do not see the difference.

@EricCousineau-TRI
Copy link

EricCousineau-TRI commented May 11, 2021

Howdy @piponazo! I can confirm the defect on my side (Mozilla Firefox 88.0.1, Ubuntu 18.04); would love to see this land!
(For whatever reason, GitHub's Rich Diff failed on this one)

On main:

https://github.com/Exiv2/exiv2/blob/15f0a600ed78165d31c2a65e1bbcd6e00677e570/README.md
image

In this patch (current rev):
https://github.com/Exiv2/exiv2/blob/b2a84f5b5fa040d22f38eb50e2306763f14f96be/README.md

image

@piponazo
Copy link
Collaborator

Ha! I actually also see the difference on Google Chrome. Maybe I was not looking to the right place the last time 😄 .

Thanks again!

@piponazo piponazo self-requested a review May 11, 2021 14:10
@piponazo piponazo merged commit 45a6916 into Exiv2:main May 11, 2021
@EricCousineau-TRI
Copy link

Wewt, thanks!!!

@EricCousineau-TRI
Copy link

(and thanks to @jwilk for fixing it!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants