Fix #1011 fix_1011_jp2_readmetadata_loop (bp #1013)

[mergify]

This is an automated backport of pull request #1013 done by Mergify.io

Cherry-pick of 1b917c3 has failed:

On branch mergify/bp/master/pr-1013
Your branch is up to date with 'origin/master'.

You are currently cherry-picking commit 1b917c3f7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:

	new file:   test/data/Jp2Image_readMetadata_loop.poc
	modified:   tests/bugfixes/github/test_CVE_2017_17725.py
	new file:   tests/bugfixes/github/test_issue_1011.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)

	both modified:   src/jp2image.cpp

To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

[D4N]

This check seems a little arbitrary to me, maybe we should find out why there's an infinite loop in the first place?

[piponazo]

I agree in which it seems a bit arbitraty (or at least we do not have a reference to know about the maximum number of boxes). My approach would be to try to merge this as it is, and create another issue to investigate about this in the future.

I was searching the JPEG 2000 specification, but it seems it is not publicly available 😢
https://www.iso.org/standard/37674.html

[piponazo]

I fixed the conflicts in this automatic PR. I will merge the changes as soon as CI is green and create a ticket to investigate the issue raised by @D4N

[codecov]

Codecov Report

Merging #1016 into master will decrease coverage by 0.01%.
The diff coverage is 81.81%.

@@            Coverage Diff             @@
##           master    #1016      +/-   ##
==========================================
- Coverage   71.24%   71.23%   -0.02%     
==========================================
  Files         148      148              
  Lines       19456    19466      +10     
==========================================
+ Hits        13861    13866       +5     
- Misses       5595     5600       +5

Impacted Files	Coverage Δ
src/jp2image.cpp	36.81% <81.81%> (+0.93%)	⬆️
src/actions.cpp	74.61% <0%> (-0.18%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02e2a52...935b44b. Read the comment docs.