Merge pull request #2347 from kevinbackhouse/quicktimevideo-size-calc

Avoid potential integer overflow in QuickTimeVideo::userDataDecoder
Exiv2 · Sep 7, 2022 · 2482159 · 2482159
2 parents 175e609 + bf4f28b
commit 2482159
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/quicktimevideo.cpp b/src/quicktimevideo.cpp
@@ -803,7 +803,7 @@ void QuickTimeVideo::userDataDecoder(size_t size_external) {
 
     tv = find(userDataReferencetags, Exiv2::toString(buf.data()));
 
-    if (size == 0 || (size - 12) <= 0)
+    if (size <= 12)
       break;
 
     else if (equalsQTimeTag(buf, "DcMD") || equalsQTimeTag(buf, "NCDT"))