fix: checking for invoice support on lnd clients while verifying connection #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael1011
requested changes
Sep 23, 2020
There was a problem hiding this comment.
Thanks for working on my obscure issue 😊
I left some comments. And one more thing I noticed is that you call it invoice support which is technically not true and might be confusing for end users. I would very much prefer calling it hold invoice support because normal invoices are always supported by LND and hold invoice support is optional and has to be enabled via a flag when building LND.
Edit: writing integration tests for this would probably be really hard but I would very much appreciate some unit tests for the added logic.
…ection Signed-off-by: rsercano <[email protected]>
rsercano
force-pushed
the
fix/checking-invoices-support-lnd
branch
from
2a8d9f6 to
4c26aff
Compare
|
My pleasure :) I fixed the review points @michael1011, will take a look at tests. |
raladev
previously approved these changes
Sep 24, 2020
ghost
reviewed
Sep 24, 2020
ghost
self-requested a review
raladev
previously approved these changes
Sep 28, 2020
|
@michael1011 good to merge from your side? |
michael1011
reviewed
Sep 29, 2020
…x/checking-invoices-support-lnd
rsercano
force-pushed
the
fix/checking-invoices-support-lnd
branch
from
da64aab to
532a332
Compare
|
Fixed @michael1011 thanks for checking! |
michael1011
approved these changes
Sep 29, 2020
ghost
approved these changes
Sep 30, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to resolve #1875
A result of getinfo where I simulated no invoice support by sending wrong rHash: @kilrau