feat: generate 2048-bit tls certs #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As discussed on the call, @sangaman can take over this PR to see if there is an easy way to make changes like this backwards compatible |
sangaman
reviewed
Jun 26, 2020
lib/grpc/GrpcServer.ts
Outdated
| const cert = pki.createCertificate(); | ||
|
|
||
| cert.publicKey = keys.publicKey; | ||
| cert.serialNumber = String(Math.floor(Math.random() * 1024) + 1); | ||
| cert.serialNumber = String(Math.floor(Math.random() * 2048) + 1); |
There was a problem hiding this comment.
I don't think this actually needs to change to use 2048 bit keys. Maybe we can make the serial number indicate that the cert is 2048 bit? Then we'd have an easy to check if existing certs are 2048 or 1024.
So something like this
cert.serialNumber = `2048-${String(Math.floor(Math.random() * 100000000))}`;That would give us serial numbers that look like "2048-" followed by a random number up to 8 digits. And I could check if a cert is 2048 bit just by seeing if the serial number starts with "2048".
|
Would you still want to merge this one? @sangaman |
sangaman
previously approved these changes
Jul 6, 2020
|
Could you squash and change the commit to the |
sangaman
changed the title
ghost
approved these changes
Aug 25, 2020
This was referenced Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generates 2048-bit TLS certificate instead of 1024-bit. Related to ExchangeUnion/xud-docker#533 (comment)