Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connext status Ready but it's not #512

Closed
kilrau opened this issue Jun 9, 2020 · 1 comment · Fixed by #513
Closed

connext status Ready but it's not #512

kilrau opened this issue Jun 9, 2020 · 1 comment · Fixed by #513
Assignees
@reliveyy
Labels
bug Something isn't working P2 mid priority

Comments

@kilrau
Copy link
Contributor

kilrau commented Jun 9, 2020 •
edited
Loading

Describe the bug
Currently on mainnet status shows connext ready:

mainnet > status
┌───────────┬────────────────────────────────────────────────┐
│ SERVICE   │ STATUS                                         │
├───────────┼────────────────────────────────────────────────┤
│ bitcoind  │ Syncing 45.22% (286689/633858)                 │
├───────────┼────────────────────────────────────────────────┤
│ litecoind │ Syncing 31.56% (586032/1856404)                │
├───────────┼────────────────────────────────────────────────┤
│ geth      │ Ready (connected to external)                  │
├───────────┼────────────────────────────────────────────────┤
│ lndbtc    │ Syncing                                        │
├───────────┼────────────────────────────────────────────────┤
│ lndltc    │ Syncing                                        │
├───────────┼────────────────────────────────────────────────┤
│ connext   │ Ready                                          │
├───────────┼────────────────────────────────────────────────┤
│ xud       │ Waiting for lndbtc, lndltc, connext            │
└───────────┴────────────────────────────────────────────────┘

whereas it's not because indra mainnet is still not up:

Connext info:
┌─────────┬─────────────────────────────────────┐
│ Status  │ connect ECONNREFUSED 127.0.0.1:5040 │
├─────────┼─────────────────────────────────────┤
│ Version │                                     │
├─────────┼─────────────────────────────────────┤
│ Address │                                     │
├─────────┼─────────────────────────────────────┤
│ Network │ connext mainnet                     │
└─────────┴─────────────────────────────────────┘

Expected behavior
status uses xud getinfo connext status, nothing else.
@kilrau kilrau added the P2 mid priority label Jun 9, 2020
@kilrau kilrau added the bug Something isn't working label Jun 9, 2020
@kilrau
Copy link
Contributor Author

kilrau commented Jun 9, 2020

I suggest we rely on xud's getinfo endpoint here. If it returns a string containing ECONNREFUSED in the "connext": { "status": field, then we print Can't connect to Connext node in status. You can remove calling the connext /health endpoint in status.

reliveyy added a commit that referenced this issue Jun 9, 2020
@reliveyy
chore(xudctl): refine connext status
27dcc94 
This PR keeps align with xud getinfo connext status.

Closes #512.
@reliveyy reliveyy mentioned this issue Jun 9, 2020
Merged
reliveyy added a commit that referenced this issue Jun 18, 2020
@reliveyy
chore(xudctl): refine connext status
986aba3 
This PR keeps align with xud getinfo connext status.

Closes #512.
raladev pushed a commit that referenced this issue Jun 18, 2020
@reliveyy
chore(xudctl): refine connext status (#513)
2a60535 
* chore(xudctl): refine connext status

This PR keeps align with xud getinfo connext status.

Closes #512.

* fix api missing in Dict

* add another status text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reliveyy reliveyy

Labels
bug Something isn't working P2 mid priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(xudctl): refine connext status ExchangeUnion/xud-docker
2 participants
@reliveyy @kilrau