Add an NBT converter for components on Velocity #237
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround to allow Prototolize to send NBT components until KyoriPowered/adventure#995 is resolved.
Using Velocity's
ComponentHolder
, I convert the component to an Adventure NBT tag (seeadventure-nbt
), then convert the Adventure NBT tag to a Querz NBT tag using a custom mapper class.Basic testing with item names, lores, and inventory titles (using Protocolize's OpenWindow and WindowItems packets) works fine on 1.20.4.
I have not tested on lower versions or old versions of Velocity that don't support 1.20.3 and therefore don't have a ComponentHolder class. Let me know if there is a better way to get the protocol version than hard-coding
ProtocolVersion.MINECRAFT_1_20_3
.