Choose minimal velocity scale to fix bc issues #1332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue found in Nalu-Wind's VOF formulation around solid boundaries. Essentially the compression and diffusion of the interface should be zero along interfaces or strange behavior occurs. The PR addresses this issue, while avoiding issues with mesh motion, by taking the local velocity scale to always be the minimum of the local velocity and the volume flow rate.
@mbkuhn the flag approach proved to be complex due to the flag being tied to balanced buoyancy. I found this as a simpler way to tackle things and to possibly get the best of both worlds. To recreate the flag approach, we can also just check if vdot ~ 0.0 and then zero out the local velocity scale rather than always taking the minimum.