Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose minimal velocity scale to fix bc issues #1332

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

wjhorne
Copy link
Contributor

@wjhorne wjhorne commented Dec 12, 2024

This PR fixes an issue found in Nalu-Wind's VOF formulation around solid boundaries. Essentially the compression and diffusion of the interface should be zero along interfaces or strange behavior occurs. The PR addresses this issue, while avoiding issues with mesh motion, by taking the local velocity scale to always be the minimum of the local velocity and the volume flow rate.

@mbkuhn the flag approach proved to be complex due to the flag being tied to balanced buoyancy. I found this as a simpler way to tackle things and to possibly get the best of both worlds. To recreate the flag approach, we can also just check if vdot ~ 0.0 and then zero out the local velocity scale rather than always taking the minimum.

@wjhorne wjhorne self-assigned this Dec 13, 2024
@mbkuhn
Copy link
Contributor

mbkuhn commented Dec 23, 2024

We've already talked about this, but I'm putting it here for the record.

Though this implementation works pretty well, we've seen it be less robust than the original volume-flux-based approach. This is probably due to instances when the velocity (within the min expression) becomes preferred, and this appears to be less stable. We think the preferred approach is to incorporate the mesh velocity into a volume-flux-based approach so we can retain the volume flux base but also address mesh motion.

@mbkuhn
Copy link
Contributor

mbkuhn commented Dec 23, 2024

we may end up needing to have something along the lines of min(volume_flux, volume_flux-mesh_velocity)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants