Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Conversation

cmcculloh-kr
Copy link

@cmcculloh-kr cmcculloh-kr commented Sep 21, 2016

When repeater completes rendering a callback is called, which in turn triggers the rendered.fu.repeater function. This callback needs to receive the data provided by the dataSource so that it can pass it along through the trigger.

I noticed when writing the unit tests that the search object was having the same event triggered on it, but, was not receiving any data. I am now passing along the data for consistency sake (and so that tests would pass since they were expecting it).

fixes #1867

To test:

  • pull changes
  • reset to 17dbe60
  • run unit tests grunt test (they should fail)
  • reset to 6894504
  • run unit tests grunt test (they should now pass)
  • runt grunt servefast
  • open http://localhost:8000/ and interact with repeaters (paging, etc) and make sure they still work.
  • review/comment on code

Copy link
Contributor

@chriscorwin chriscorwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SEEMS TO WORK

Unit tests seem to pass for the testing conditions they set.

@chriscorwin chriscorwin merged commit 7b15b88 into ExactTarget:master Sep 22, 2016
@cmcculloh-kr cmcculloh-kr deleted the GH1867---paging-is-not-working-as-it-did-previously-for-repeater-with-infinite-scroll branch October 5, 2016 19:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paging is not working as it did previously for repeater with infinite scroll
3 participants