Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose create_library_signal and create_tag #33

Merged
merged 6 commits into from
Jul 8, 2021

Conversation

oyvindwe
Copy link
Contributor

@oyvindwe oyvindwe commented Jul 8, 2021

This change is Reviewable

@oyvindwe oyvindwe requested a review from hallarak July 8, 2021 12:37
@oyvindwe oyvindwe marked this pull request as draft July 8, 2021 12:37
Copy link
Contributor

@hallarak hallarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 12 files at r1, 4 of 4 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved


exabel_data_sdk/client/api/time_series_api.py, line 130 at r2 (raw file):

                    and if ns1 is not empty, all three namespaces must be equal.
            series: The time series data
            create_tag: Set to true to create a tag for every entity type a signal has time series

I think we try to keep the description of parameters on the same indentation.

Fix indentation
Copy link
Contributor Author

@oyvindwe oyvindwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 11 of 13 files reviewed, all discussions resolved


exabel_data_sdk/client/api/time_series_api.py, line 130 at r2 (raw file):

Previously, hallarak (Øystein Hallaråker) wrote…

I think we try to keep the description of parameters on the same indentation.

Done.

Copy link
Contributor

@hallarak hallarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4.
Reviewable status: 12 of 13 files reviewed, all discussions resolved

Copy link
Contributor

@hallarak hallarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@hallarak hallarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r5.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@oyvindwe oyvindwe marked this pull request as ready for review July 8, 2021 13:40
Copy link
Contributor

@hallarak hallarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r6.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@oyvindwe oyvindwe merged commit 4c1419d into Exabel:main Jul 8, 2021
@oyvindwe oyvindwe deleted the skip-create branch July 8, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants