Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not expose geokey-communitymaps extension #405

Merged
merged 1 commit into from
Aug 19, 2018

Conversation

josokinas
Copy link
Member

Both Community Maps webapp and geokey-communitymaps extension are private projects that are not exposed to anyone apart Mapping for Change. However GeoKey is an open source project. We should not expose any connection between these two projects.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.428% when pulling 5cdf708 on bugfix/no-communitymaps-exposure into 537654e on master.

Copy link
Contributor

@JamesBradbury JamesBradbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes these changes should never have been committed. They may be worth adding to the documentation for geokey-communitymaps.

@JamesBradbury JamesBradbury merged commit 6800d7c into master Aug 19, 2018
@josokinas josokinas deleted the bugfix/no-communitymaps-exposure branch August 20, 2018 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants