New core API to request server info #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ensions), to be used by Sapelli. Test case included. Signed-off-by: Matthias Stevens <[email protected]>
|
My only concern would be if to expose superuser extensions? Because extension can be made to be used by superusers only. In this case, it would be worth checking if the request user is a superuser or a regular user. What do you think? |
the info API uses this information to report the versions of installed extensions. Because version is an optional argument of register() this should not break existing extension which do not (yet) pass their version to GeoKey. Signed-off-by: Matthias Stevens <[email protected]>
- check if 'version' field exists on extension dict - hide superuser extensions unless request comes from superuser - improved test case Also added a deregister() method for extensions (only for testing purposes) Signed-off-by: Matthias Stevens <[email protected]>
…changes to extension registration logic. Also added proper setUp() and tearDown(). This should resolve the travis failures on this branch... Signed-off-by: Matthias Stevens <[email protected]>
mstevens83
added a commit
that referenced
this pull request
Dec 11, 2015
New core API to request server info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added core API to request server info (geokey version + installed exTensions), to be used by Sapelli.
Test case included.
Signed-off-by: Matthias Stevens [email protected]