Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shuffling #250

Merged
merged 3 commits into from
Aug 12, 2023
Merged

Shuffling #250

merged 3 commits into from
Aug 12, 2023

Conversation

jeremiedb
Copy link
Member

@jeremiedb jeremiedb commented Aug 12, 2023

  • Use dynamic threading (no more @threads :static). fix Threading issue #248
  • Use ordered, no replacement sampling when geting bins edges
  • New model default: nrounds=100, eta=0.1, nbins=64, max_depth=6

@codecov
Copy link

codecov bot commented Aug 12, 2023

Codecov Report

Patch coverage: 94.73% and no project coverage change.

Comparison is base (897ffca) 51.08% compared to head (a70d925) 51.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #250   +/-   ##
=======================================
  Coverage   51.08%   51.08%           
=======================================
  Files          21       21           
  Lines        1979     1979           
=======================================
  Hits         1011     1011           
  Misses        968      968           
Files Changed Coverage Δ
src/gpu/fit.jl 0.00% <0.00%> (ø)
src/models.jl 95.23% <ø> (ø)
src/eval.jl 68.18% <100.00%> (ø)
src/fit-utils.jl 92.21% <100.00%> (ø)
src/fit.jl 94.17% <100.00%> (ø)
src/loss.jl 89.36% <100.00%> (ø)
src/predict.jl 92.17% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Threading issue
1 participant