Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split fix #202

Merged
merged 7 commits into from
Dec 25, 2022
Merged

Split fix #202

merged 7 commits into from
Dec 25, 2022

Conversation

jeremiedb
Copy link
Member

Fix for buggy cumulative gradient in hL/hR for gain calculations.

@codecov-commenter
Copy link

codecov-commenter commented Dec 25, 2022

Codecov Report

Base: 48.18% // Head: 47.82% // Decreases project coverage by -0.36% ⚠️

Coverage data is based on head (701efd9) compared to base (61e7085).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
- Coverage   48.18%   47.82%   -0.37%     
==========================================
  Files          20       20              
  Lines        1573     1560      -13     
==========================================
- Hits          758      746      -12     
+ Misses        815      814       -1     
Impacted Files Coverage Δ
src/gpu/find_split_gpu.jl 0.00% <0.00%> (ø)
src/find_split.jl 90.26% <100.00%> (-1.08%) ⬇️
src/fit.jl 94.54% <100.00%> (ø)
src/models.jl 97.43% <0.00%> (+0.85%) ⬆️
src/EvoTrees.jl 9.09% <0.00%> (+9.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jeremiedb
Copy link
Member Author

Fix #201

@jeremiedb jeremiedb merged commit 717304d into main Dec 25, 2022
@jeremiedb jeremiedb deleted the split-fix branch December 26, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants