Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MLJ metadata declarations so that new docstrings get written to the MLJ model registry #180

Merged
merged 2 commits into from
Oct 27, 2022
Merged

Fix MLJ metadata declarations so that new docstrings get written to the MLJ model registry #180

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
008063b
rm descr from metadata_model declarations
ablaom Oct 27, 2022
fd45084
rm redundant constants
ablaom Oct 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/MLJ.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,6 @@ end


# Metadata
const EvoTreeRegressor_desc = "Regression models with various underlying methods: least square, quantile, logistic, gamma (deviance), tweedie (deviance)."
const EvoTreeClassifier_desc = "Multi-classification with softmax and cross-entropy loss."
const EvoTreeCount_desc = "Poisson regression fitting λ with deviance minimization."
const EvoTreeGaussian_desc = "Deprecated - Use EvoTreeMLE with `loss=:normal` instead. Gaussian maximum likelihood of μ and σ."
const EvoTreeMLE_desc = "Maximum likelihood methods supporting Normal/Gaussian and Logistic distributions."

MMI.metadata_pkg.(
(EvoTreeRegressor, EvoTreeClassifier, EvoTreeCount, EvoTreeGaussian),
Expand All @@ -119,7 +114,6 @@ MMI.metadata_model(
target_scitype = AbstractVector{<:MMI.Continuous},
weights = false,
path = "EvoTrees.EvoTreeRegressor",
descr = EvoTreeRegressor_desc,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can remove the short descriptions in lines 97-101 as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Done.

)

MMI.metadata_model(
Expand All @@ -131,7 +125,6 @@ MMI.metadata_model(
target_scitype = AbstractVector{<:MMI.Finite},
weights = false,
path = "EvoTrees.EvoTreeClassifier",
descr = EvoTreeClassifier_desc,
)

MMI.metadata_model(
Expand All @@ -143,7 +136,6 @@ MMI.metadata_model(
target_scitype = AbstractVector{<:MMI.Count},
weights = false,
path = "EvoTrees.EvoTreeCount",
descr = EvoTreeCount_desc,
)

MMI.metadata_model(
Expand All @@ -155,7 +147,6 @@ MMI.metadata_model(
target_scitype = AbstractVector{<:MMI.Continuous},
weights = false,
path = "EvoTrees.EvoTreeGaussian",
descr = EvoTreeGaussian_desc,
)

MMI.metadata_model(
Expand All @@ -167,7 +158,6 @@ MMI.metadata_model(
target_scitype = AbstractVector{<:MMI.Continuous},
weights = false,
path = "EvoTrees.EvoTreeMLE",
descr = EvoTreeMLE_desc,
)

"""
Expand Down